Open
Conversation
nandosobral03
requested review from
chrisreddington and
leereilly
as code owners
DSIMS559
approved these changes
Jan 21, 2026
| } | ||
|
|
||
| // GenerateSkyline creates a 3D model with ASCII art preview of GitHub contributions for the specified year range, or "full lifetime" of the user | ||
| func GenerateSkyline(startYear, endYear int, targetUser string, full bool, output string, artOnly bool) error { |
|
enter ytdEnd string) error { |
Shakacro
approved these changes
Jan 26, 2026
Shakacro
approved these changes
Jan 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Another potential proposal for to address #33
With this change you can now do.
% ./gh-skyline --user nandosobral03 --year-to-date
% ./gh-skyline --user nandosobral03 --year-to-date --until 2025-01-01
And with this generate the skyline for commits from the past year (by default matching with what is shown by default on your github profile)
I'm not 100% sure about the CLI UX but wrote this mainly as something I wanted to use and to propose an alternative to the period based solution. It does have to it's favor that we don't need to worry about varying widths since it's the same number of weeks as the yearly solution